[PATCH] tag: warn users about tag/branch possible name conflicts

[Nicolas Dumazet]

Hello!

2010/4/19 Sune Foldager <cryo at cyanite.org>:
> On 19-04-2010 10:51, Nicolas Dumazet wrote:
>>
>> diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
>> --- a/mercurial/localrepo.py
>> +++ b/mercurial/localrepo.py
>> @@ -164,9 +164,13 @@
>>              if c in allchars:
>>                  raise util.Abort(_('%r cannot be used in a tag name') %
>> c)
>>
>> +        branches = self.branchtags()
>
> self.branchmap() is quicker, as it just returns the internal dictionary
> without filtering for closed heads, reversing direction etc., which you
> don't need here.

Of course! I first discarded it because I thought we did need to
filter closed heads, but it does not matter as we're not even
accessing the dictionary keys =)

Resending in a bit, thanks for your reviews!

Cheers,
-- 
Nicolas Dumazet — NicDumZ