[PATCH 1/4] updated sass test to make it work with sass 3

Denis Defreyne denis.defreyne at stoneship.org
Tue Apr 13 09:49:08 UTC 2010


---
 test/filters/test_sass.rb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/filters/test_sass.rb b/test/filters/test_sass.rb
----------cut-here-end-----------------------

We should be able to exclude the stats.

Following a discussion on IRC, it seems that we do not _always_ want to
remove line after "---". Afterall, until then this line was considered legal
and this might cause problem.
Hence the idea of an option.

I've named it --gitcompat (or --git-compat ?) after Henrik's suggestion, but I am
not completely satisfied by the idea of having to refer to git for this option.
If you can think of a better name, I'm buying it!


My first idea when writing this patch was more generic: seeing the --scissors
option in git man pages, I tried writing something along the lines of 
--discard-first-chunk/--discard-last-chunk that would have split the commit
message at each (---/<8/8>) boundaries, and would have offered the possibility
to discard the first chunk (patch is pasted as a follow-up to a discussion),
or the last chunk (git/kernel style annotations at the end of commit messages),
or both.
However, looking a bit around for various occurences of "cut here", it seems
that we tend to use various formats (-x-x-x, <8---8>, etc...), and that
feature would not be generic enough to be useful. (Think, for example, of
mails that include several cut-here sections).
I know, sometimes I am just too naive!

If you are under the impression that I'm wrong, and that there is in fact, a
reliable heuristic to cover most of those so-called scissors occurences, I'm
interested.


Regards,

Nicolas.


More information about the Mercurial-devel mailing list