[PATCH 0 of 1 RFC] --- and scissor marks in mails inlining patches?

Benoit Boissinot bboissin at gmail.com
Thu Apr 22 05:24:58 CDT 2010


On Thu, Apr 22, 2010 at 11:26 AM, Nicolas Dumazet <nicdumz at gmail.com> wrote:
> Hello!
>
> This patch is related to issue2148, where an user complained that some git
> patches were wrongly parsed. For example, a mail using such header:
>
> ----------cut-here-start-----------------------
> From 955a3853069a0d7029668ecb27f9300ba6f84da0 Mon Sep 17 00:00:00 2001
> From: Denis Defreyne <denis.defreyne at stoneship.org>
> Date: Tue, 13 Apr 2010 11:49:08 +0200
> Subject: [PATCH 1/4] updated sass test to make it work with sass 3
>
> ---
>  test/filters/test_sass.rb |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

I think it should be "--- " not "---".


>
> Following a discussion on IRC, it seems that we do not _always_ want to
> remove line after "---". Afterall, until then this line was considered legal
> and this might cause problem.

Well but we already know it's always possible to break the importer,
for example just paste a patch in the commit message.

Benoit


More information about the Mercurial-devel mailing list