[PATCH 3 of 3 resend] log: add --diffstat for diffstat output

Matt Mackall mpm at selenic.com
Thu Apr 29 14:15:27 CDT 2010


On Thu, 2010-04-29 at 23:05 +0900, Yuya Nishihara wrote:
> Matt Mackall wrote:
> > On Wed, 2010-04-07 at 01:08 +0900, Yuya Nishihara wrote:
> > > # HG changeset patch
> > > # User Yuya Nishihara <yuya at tcha.org>
> > > # Date 1270049712 -32400
> > > # Node ID bad5a14a28c946f7c211dc49fc6baa8625d658dc
> > > # Parent  884b72e36da4032bf2fe02c21833b7c1a4f2392b
> > > log: add --diffstat for diffstat output
> > > 
> > > log --diffstat shows diffstat in place of patch output.
> > 
> > I've queued your first two patches. This one makes me wonder why the
> > option name is different.
> 
> I wasn't sure whether --stat or --diffstat would be better,
> then borrowed --diffstat from churn.

Hmm. We should pick one name for this globally and stick with it, and
hide whichever name we decide not to use. Opinions?

> > Also, it seems like we'll be able to add options to log indefinitely
> > just to keep parity with diff, never mind log-related options. It
> > already has a page-full.
> 
> Hmm, do you mean: yet we can possibly add --stat, --git, --show-function,
> --unified, etc. to log, it's too much, so we shouldn't?

Well, it's something to think about. But I can definitely see diffstats
being useful for looking at logs, so I can probably be convinced to take
this.

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list