[PATCH 0 of 3] support for branch-based access control

Bill Barry after.fallout at gmail.com
Thu Apr 29 14:42:41 CDT 2010


Welcome to the list. Next time you send a patch, please remember that it 
is preferred to send them inline instead of attachments here. This makes 
it far easier to reply to the patches. Your patch might get refused 
without even being looked at because of this.

My initial reaction reading these patches is that something is wrong in 
patch 1 here:

+    for rev in xrange(repo[node], len(repo)):
+        branch = repo[rev].branch()
+        if deny and deny(branch):
+            raise util.Abort(_('acl: user "%s" denied on branch "%s"')
+            % (user, branch))
+        if allow and not allow(branch):
+            raise util.Abort(_('acl: user "%s" not allowed on branch "%s"')
+            % (user, branch))
+        ui.debug('acl: allowing user "%s" on branch "%s"\n' % (user, branch))
+
+    allow = _buildmatch(ui, repo, user, ALLOW_FILES)
+    deny = _buildmatch(ui, repo, user, DENY_FILES)
 
     for rev in xrange(repo[node], len(repo)):
         ctx = repo[rev]

It seems incorrect to be doing this for loop twice.

elifarley at gmail.com wrote:
> Now it is possible to allow or deny write access to named branches of a repository when receiving incoming changesets (via 'pretxncommit' and 'pretxnchangegroup').
>
> This functionality is found on Subversion, so users migrating from SVN may find it useful.
>
>
>  hgext/acl.py       |  42 +++++++++++++++++++++++------
>  hgext/acl.py       |  68 ++++++++++++++++++++++++++++++++++++++----------
>  tests/test-acl.out |  75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 162 insertions(+), 23 deletions(-)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
>
>   



More information about the Mercurial-devel mailing list