[PATCH 2 of 3] acl: update doc string for branch-based access control

Martin Geisler mg at aragost.com
Thu Apr 29 17:29:50 CDT 2010


Matt Mackall <mpm at selenic.com> writes:

> On Thu, 2010-04-29 at 16:44 -0300, Elifarley Callado Coelho Cruz wrote:
>>
>> hg email -i -d -r 11039:11041 -s "support for branch-based access
>> control" --to mercurial-devel at selenic.com
>
> Huh. So there's this sad situation:
>
>  -a --attach       send patches as attachments
>  -i --inline       send patches as inline attachments
>
> An "inline attachment" is a regular attachment that has a
> Content-Dispostion of "inline". And that's an entirely different thing
> from just sticking a patch in the body of a message.

I forget what email client you are using, but it sounds like it's a
slightly broken one just like Gmail's web interface... I just did some
testing and Gmail will show a patch inline when it has Content-Type:
text/plain and Content-Dispostion: inline.

With Content-Type: text/x-diff or text/x-patch it will show up as an
attachment despite the inline disposition -- I guess this is the problem
people are having?

Could we simply change the content type? I'm suggesting this since it
still feel wrong to me to just jam a bunch of bytes into an email body
and hope for the best. With an attachment there is a little more control
over things.

-- 
Martin Geisler

aragost Trifork
Professional Mercurial support
http://aragost.com/mercurial/


More information about the Mercurial-devel mailing list