[PATCH 3 of 3] Added tests for asterisk and for OS-level groups

Matt Mackall mpm at selenic.com
Thu Apr 29 21:23:21 CDT 2010


On Wed, 2010-04-28 at 14:00 -0500, Matt Mackall wrote:
> On Wed, 2010-04-28 at 11:23 -0300, elifarley at gmail.com wrote:
> > tests/test-acl     |   47 +++++++
> >  tests/test-acl.out |  322 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 369 insertions(+), 0 deletions(-)
> > 
> > 
> > # HG changeset patch
> > # User Elifarley Callado Coelho Cruz <elifarley at gmail.com>
> > # Date 1272463858 10800
> > # Node ID f778e9a29e2fded4208c2d76688103ac81aa281c
> > # Parent  b337c7f1a841eb1d545163d5c8751710f1c34dda
> > Added tests for asterisk and for OS-level groups.
> > 
> > diff --git a/tests/test-acl b/tests/test-acl
> > --- a/tests/test-acl
> > +++ b/tests/test-acl
> ...
> > \ No newline at end of file
> 
> contrib/check-code.py caught this:
> 
> tests/test-acl:160:
>  > groupdel $G1 || exit 1
>  no trailing newline
> 
> Fixed. All three are queued, thanks.

And then I discovered your test is using groupadd/useradd. Shame on me
for not reading more closely. Tests definitely shouldn't be modifying
the system config, which makes this test a little tricky.

I've amended the test to use a helper extension that fakes a group.

-- 
http://selenic.com : development and support for Mercurial and Linux




More information about the Mercurial-devel mailing list