[PATCH STABLE] dirstate: ignore symlinks when fs cannot handle them (issue1888)

[Martin Geisler]

Matt Mackall <mpm at selenic.com> writes:

> On Mon, 2010-08-09 at 16:20 +0200, Martin Geisler wrote:
>
>> Yes, that works! The performance penalty is now pretty benign as
>> shown here where I ran 'hg perfstatus' 10 times:
>> 
>>   Before:          After:
>>   min: 0.544703    min: 0.546549
>>   med: 0.547592    med: 0.548881
>>   avg: 0.549146    avg: 0.548549
>>   max: 0.564112    max: 0.551504
>> 
>> The median time is increased about 0.24%. I pushed the patch as
>> changeset ca6cebd8734e.
>
> Thanks, looks good.

You're welcome, thanks for pulling the patch to quickly :-)

> For reference, I generally only pay attention to the min numbers in
> these tuning benchmarks. Most of the major sources of noise in these
> benchmarks are additive-only (scheduling, power management, disk cache
> misses, recompiling), while things that can positively influence it
> (eg unusually good cache alignment) are pretty rare and minor. So
> looking at min gives us the least-noisy view down into the thing we're
> trying to tune.

Agreed -- this is good advice.

-- 
Martin Geisler

Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20100809/ec356549/attachment.pgp>