[PATCH] convert: Using --dest-type svn crashed, if the source repo used tags.

Daniel J. Lauk daniel.lauk at gmail.com
Wed Aug 11 04:53:39 CDT 2010


# HG changeset patch
# User Daniel J. Lauk <daniel.lauk at gmail.com>
# Date 1281519966 -7200
# Node ID e1e87c378c830e382cc96478c0a1c0ea49a97ee4
# Parent  8b452fe4bf506a1a08bbc7e1bac81aceda8f4d10
convert: Using --dest-type svn crashed, if the source repo used tags.

The convert extension requires puttags(self, tags) to return a sequence
for a multi-variable assignment.  If puttags implicitly returns None,
the code will break when trying to un-pack None for assignment.

diff --git a/hgext/convert/subversion.py b/hgext/convert/subversion.py
--- a/hgext/convert/subversion.py
+++ b/hgext/convert/subversion.py
@@ -1158,3 +1158,4 @@

     def puttags(self, tags):
         self.ui.warn(_('XXX TAGS NOT IMPLEMENTED YET\n'))
+        return None, None


More information about the Mercurial-devel mailing list