Fwd: [PATCH] convert: Using --dest-type svn crashed, if the source repo used tags.

[Daniel J. Lauk]

Sorry, forgot to hit "reply-all" instead of "reply".


---------- Forwarded message ----------
From: Daniel J. Lauk <daniel.lauk at gmail.com>
Date: 2010/8/11
Subject: Re: [PATCH] convert: Using --dest-type svn crashed, if the
source repo used tags.
To: Martin Geisler <mg at aragost.com>


>>> Since it looks like this part of the code is not used much, could you
>>> look into writing a test for this as well? There is already a
>>> test-convert-svn-sink script that you can expand.
>>
>> Sure, why not? I'll give it a go.
>
> Thanks, that would be excellent! :)

OK, I extended test-convert-svn-sink.
I tried my best to verify everything is fine by running "make
test-convert-svn-sink", both with and without the previous patch
applied (using the mq extension). As one would expect, it fails
without the applied patch and succeeds with it. I also ran "make
tests" to make sure that I did not break anything accidentially.

Now, before I send in the second patch, I guess I'd like to pull in
the previous patch, which you already comitted, and then remove my
patch from the queue. Am I right on this?
If so, where should I pull from to get the aforementioned changeset
7e5f5e5858f9? I originally cloned from
http://selenic.com/repo/hg-stable, but the changeset did not yet show
up there.

Thanks in advance!

Cheers,
DJ