Tiny patch for bug in revert API

Mads Kiilerich mads at kiilerich.com
Fri Aug 13 14:00:24 CDT 2010


On 08/13/2010 08:07 PM, Xavier Snelgrove wrote:
> Hi all,
>
> Please let me know if I'm submitting this patch incorrectly,

See http://mercurial.selenic.com/wiki/ContributingChanges . The only 
minor issues is that you "should" have used patchbomb. And the first 
line of the description is a bit too long. (And the description isn't 
100% correct ...)

And try to configure your mailer so it wrap the lines or don't use 
quoted-printable. On 
http://www.selenic.com/pipermail/mercurial-devel/2010-August/023593.html 
you can (on a narrow screen) see why.

> as I haven't done this before. It fixes a bug in the python API to the "revert" command that required a date parameter to be passed in. It's modifies all of 2 lines of code, and I believe it is correct.

Well ... the API is defined by the code, so I wouldn't call it a bug. 
The API is that date must be passed - and you should probably use date=None.

But I think that your patch is a good change of the API.

/Mads


More information about the Mercurial-devel mailing list