Bug in description handling

Matt Mackall mpm at selenic.com
Fri Aug 13 16:13:50 CDT 2010


On Fri, 2010-08-13 at 21:45 +0200, Martijn Pieters wrote:
> On Fri, Aug 13, 2010 at 21:14, Martijn Pieters <mj at zopatista.com> wrote:
> > I can look into porting http://bugs.python.org/issue6202 for use in
> > Mercurial. In any case, getpreferredencoding has been fixed for Python
> > 2.7, so this only needs to be backported for python 2.6 and earlier.
> 
> I've created a patch that simply re-uses the posix
> getpreferredencoding code for python on mac before version 2.7, and
> removes the setlocale call for the same platform.
> 
> All tests pass with the patch applied. hgdebuginstall output:
> 
> $ hg debuginstall
> Checking encoding (UTF-8)...
> Checking extensions...
> Checking templates...
> Checking patch...
> Checking commit editor...
> Checking username...
> No problems detected

Alright, now we've got three patches for this and we're going to need to
pick one. This patch looks ok except for monkeypatching locale - we
should just directly find an encoding and skip the def/monkeypatch
steps.

> Download it from:
> http://bitbucket.org/mjpieters/mercurial-crew-mq/src/tip/pending/getpreferredencoding.patch

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list