[PATCH 1 of 2] tests: unify test-patchbomb

Martin Geisler mg at lazybytes.net
Tue Aug 17 07:05:46 CDT 2010


Christian Ebert <blacktrash at gmx.net> writes:

> * Martin Geisler on Tuesday, August 17, 2010 at 12:20:55 +0200
>> I can also get hold of the raw bytes, but I normally pipe the message
>> From Gnus as UTF-8 text since this was what worked last time I had to
>> import a patch with an author name containing non-ASCII characters.
>
> Well, the test in question is about non-utf-8:
>
> iso-8859-1 patch:
>   $ python -c 'fp = open("isolatin", "wb"); fp.write("h\xF6mma!\n"); fp.close();'
>   $ hg commit -A -d '5 0' -m 'charset=us-ascii; content-transfer-encoding: 8bit'
>   adding isolatin

Yes, I know that. I know it's very practical and useful that we just
pour the bytes into a mail and ship it off, even when the encoding is
inconsistent in those bytes.

I'm just saying that I'm not sure it's correct to do so. We had a recent
bug report from Dan about not being able to send a patch that changed
line-endings. I think this is the same kind of problem.

-- 
Martin Geisler

Mercurial links: http://mercurial.ch/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20100817/7aebe345/attachment.pgp>


More information about the Mercurial-devel mailing list