[PATCH 2 of 2] mq/qqueue: enable renaming of active queue

Henrik Stuart hg at hstuart.dk
Tue Aug 17 14:47:59 CDT 2010


On 15-08-2010 18:04, Yann E. MORIN wrote:
[snip]
> @@ -2704,6 +2710,30 @@
>               _addqueue(_defaultqueue)
>           _addqueue(name)
>           _setactive(name)
> +    elif opts.get('rename'):
> +        current = _getcurrent()
> +        if name == current:
> +            raise util.Abort(_('can\'t rename "%s" to its current name') % name)
> +        if name in existing:
> +            raise util.Abort(_('queue "%s" already exists') % name)
> +
> +        olddir = _queuedir(current)
> +        newdir = _queuedir(name)
> +
> +        if os.path.exists(newdir):
> +            raise util.Abort(_('existing patch directory for queue "%s"') % name)

Perhaps 'directory "%s" already exists, but isn\'t a queue' would be a 
better wording?

[snip]

All in all, I think the patches look fine and ready to be integrated.

-- 
Kind regards,
   Henrik Stuart


More information about the Mercurial-devel mailing list