[PATCH 2 of 2] mq/qqueue: enable renaming of active queue

Henrik Stuart hg at hstuart.dk
Tue Aug 17 16:36:41 CDT 2010


On 17-08-2010 22:56, Yann E. MORIN wrote:
> Henrik, All,
>
> On Tuesday 17 August 2010 21:47:59 Henrik Stuart wrote:
>> On 15-08-2010 18:04, Yann E. MORIN wrote:
>>> +        if os.path.exists(newdir):
>>> +            raise util.Abort(_('existing patch directory for queue "%s"') % name)
>> Perhaps 'directory "%s" already exists, but isn\'t a queue' would be a
>> better wording?
>
> Yes, it's better, but we shoud use newdir as the argument, instead of name.
> Should I resubmit an updated version for this?

I've just changed it (and removed the signed-off-by bit in the commit 
message). Both changes are pushed to crew now.

>> All in all, I think the patches look fine and ready to be integrated.
>
> Thanks!

Thank you for your contribution.

-- 
Kind regards,
   Henrik Stuart


More information about the Mercurial-devel mailing list