Should we use subrepos ourselves?

[Steve Borho]

On Wed, Aug 18, 2010 at 11:49 AM, Patrick Mézard <pmezard at gmail.com> wrote:
> Le 18/08/10 18:25, Steve Borho a écrit :
>> On Wed, Aug 18, 2010 at 11:07 AM, Patrick Mézard <pmezard at gmail.com> wrote:
>>> Le 18/08/10 17:59, Steve Borho a écrit :
>>>> On Wed, Aug 18, 2010 at 10:57 AM, Patrick Mézard <pmezard at gmail.com> wrote:
>>>>> Le 18/08/10 17:47, Steve Borho a écrit :
>>>>>> On Wed, Aug 18, 2010 at 10:40 AM, Colin Caughie
>>>>>> <c.caughie at indigovision.com> wrote:
>>>>>>>> -----Original Message-----
>>>>>>>> From: mercurial-devel-bounces at selenic.com [mailto:mercurial-devel-
>>>>>>>> bounces at selenic.com] On Behalf Of Matt Mackall
>>>>>>>> Sent: 18 August 2010 15:57
>>>>>>>> To: Martin Geisler
>>>>>>>> Cc: Mercurial Development List
>>>>>>>> Subject: Re: Should we use subrepos ourselves?
>>>>>>>>
>>>>>>>> On Wed, 2010-08-18 at 16:51 +0200, Martin Geisler wrote:
>>>>>>>>> Hi guys,
>>>>>>>>>
>>>>>>>>> I had a meeting with my customer today where we dicussed subrepos
>>>>>>>> (as
>>>>>>>>> usual) and half-joking, they suggested that we try using them
>>>>>>>> ourselves
>>>>>>>>> for the Mercurial repository...
>>>>>>>>
>>>>>>>> It might indeed help us improve subrepos. On the other hand, it's
>>>>>>>> definitely not a good use case for them and other people might
>>>>>>>> decide to
>>>>>>>> follow our bad example.
>>>>>>>
>>>>>>> What about the TortoiseHg project? Seems like making hg a subrepo of TortoiseHg would be a good use case, and could result in improved subrepo support in both TortoiseHg and Mercurial itself.
>>>>>>
>>>>>> I want to use subrepos for thg-winbuild, and perhaps thg itself (the
>>>>>> shell extension C++ code could/should be split off).  But I would
>>>>>> really like read-only subrepos before I do the former.
>>>>>
>>>>> Read-only like "fail on commit" ?
>>>>
>>>> Read-only, as-in, skip these when you push the main repo
>>>
>>> What's the rationale?
>>> You modify them but don't want to push back?
>>> You don't modify them but have problem when pushing back nonetheless (auth issues blocking changes checking come to mind) ?
>>
>> I never modify subrepos of thg-winbuild; I'm just collecting the repos
>> together to build installers.  And I don't want my pushes to
>> thg-winbuild to fail if, for example, the perfarce repo is temporarily
>> unreachable.  I also don't want my pushes to take tens of minutes if
>> bitbucket is lagging.
>
> I suppose not pushing if the subrepo current revision is an ancestor of the revision in .hgsubstate or the revision itself, should be enough?

That seems reasonable.

-- 
Steve Borho