[PATCH] mq/qqueue: add a -d alias to --delete option

Henrik Stuart hg at hstuart.dk
Thu Aug 19 14:02:32 CDT 2010


On 15-08-2010 16:27, Yann E. MORIN wrote:
> All,
>
> On Thursday 12 August 2010 19:34:12 Yann E. MORIN wrote:
>> On Thursday 12 August 2010 19:06:22 Alecs King wrote:
>>> mq/qqueue: add a -d alias to --delete option
>> For what my opinion is worth, I would advise not to add this alias.
>> Deleting a queue with existing patches will simply consign all those
>> patches to oblivion,
>
> Which is blatantly wrong. My bad. The patch directory is not removed
> when a queue is deleted.
>
> So, why is the patch directory kept when we delete a queue? Is that
> something releated to quilt again?
>
> Do we want to remove the patch dir on queue deletion?
> If so, should we do it systematically, or offer the user the choice
> to keep/remove it?
>
> For information, in my attempt to implement queue renaming, I've been
> beaten by this, and agreeing that the patch dir should be removed would
> simplify the renaming code.

We have previously had issues with people complaining they lost data 
because they called qremove on a non-versioned queue, which physically 
deletes the file, so I simply decided to keep the queue directory around 
so the patches are still available even though we have forgotten about 
them. (I think it was proposed we do something alike for qremove, but I 
don't think it was ever implemented).

It may be inconvenient at times, but I think with the added --purge 
option, we have something that should satisfy everyone and their 
paranoia. :o)

-- 
Kind regards,
   Henrik Stuart


More information about the Mercurial-devel mailing list