[PATCH] mq/qqueue: add a -d alias to --delete option

Yann E. MORIN yann.morin.1998 at anciens.enib.fr
Thu Aug 19 16:35:37 CDT 2010


Henrik, All,

On Thursday 19 August 2010 21:02:32 Henrik Stuart wrote:
> On 15-08-2010 16:27, Yann E. MORIN wrote:
> > Do we want to remove the patch dir on queue deletion?
> > If so, should we do it systematically, or offer the user the choice
> > to keep/remove it?
[--SNIP--]
> We have previously had issues with people complaining they lost data 
> because they called qremove on a non-versioned queue, which physically 
> deletes the file, so I simply decided to keep the queue directory around 
> so the patches are still available even though we have forgotten about 
> them. (I think it was proposed we do something alike for qremove, but I 
> don't think it was ever implemented).

For qremove, we have --keep that just removes the patch from the list,
but not from disk.

> It may be inconvenient at times, but I think with the added --purge 
> option, we have something that should satisfy everyone and their 
> paranoia. :o)

Yes, that was the conclusion I came to, people complaining about lost
files even after they (indirectly) asked for their removal. That's why
I came up with --purge, which was imho a good compromise: keep the
current semantic and behavior of --delete and the possibility to retrieve
the patches, and offer a new option with a new semantic, to get rid of
both the queue and the patches.

Thank you again!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'




More information about the Mercurial-devel mailing list