[PATCH 2 of 3] patchbomb: with --confirm display series details and ask for confirmation

[Greg Ward]

On Thu, Aug 26, 2010 at 11:24 AM, Christian Ebert <blacktrash at gmx.net> wrote:
> # HG changeset patch
> # User Christian Ebert <blacktrash at gmx.net>
> # Date 1282836101 -3600
> # Node ID 594b41c8ff5a81d99c4408a41f65172c9ea595e0
> # Parent  5ef5d9a1d056449555c93dddb0e7887f21edf4b1
> patchbomb: with --confirm display series details and ask for confirmation

Better commit message:

  patchbomb: add --confirm option to show series details and ask for
confirmation

> The confirmation check summary looks like this:
>
>  Patchbomb details:
>  Subject: [patch 0 of x [flags]] subject of intro or single patch
>  Subject: [patch 1 of x [flags]] subject
>  [ ... ]
>  From: sender
>  To: recipient(s)
>  Cc: if present or empty
>  Bcc: if present or empty
>  Reply-To: if present or empty

I agree with Mads about order.

Also: from reading the code, it appears that you do not print (say)
"Cc" or "Bcc" if there is no such header.  That feels right to me.  Is
that the actual behaviour?

> +        if not ans.lower().startswith('y'):
> +            ui.write(_('patchbomb canceled\n'))
> +            return

Spelling: it's "cancelled" according to my recollection and my local aspell.

Other than that, I like it.

Greg