[PATCH 2 of 3] patchbomb: with --confirm display series details and ask for confirmation

Christian Ebert blacktrash at gmx.net
Fri Aug 27 09:34:17 CDT 2010

* Greg Ward on Friday, August 27, 2010 at 09:07:05 -0400
> On Thu, Aug 26, 2010 at 11:24 AM, Christian Ebert <blacktrash at gmx.net> wrote:
>> # HG changeset patch
>> # User Christian Ebert <blacktrash at gmx.net>
>> # Date 1282836101 -3600
>> # Node ID 594b41c8ff5a81d99c4408a41f65172c9ea595e0
>> # Parent  5ef5d9a1d056449555c93dddb0e7887f21edf4b1
>> patchbomb: with --confirm display series details and ask for confirmation
> Better commit message:
>  patchbomb: add --confirm option to show series details and ask for
> confirmation


>> The confirmation check summary looks like this:
>>  Patchbomb details:
>>  Subject: [patch 0 of x [flags]] subject of intro or single patch
>>  Subject: [patch 1 of x [flags]] subject
>>  [ ... ]
>>  From: sender
>>  To: recipient(s)
>>  Cc: if present or empty
>>  Bcc: if present or empty
>>  Reply-To: if present or empty
> I agree with Mads about order.

Me too.

> Also: from reading the code, it appears that you do not print (say)
> "Cc" or "Bcc" if there is no such header.  That feels right to me.  Is
> that the actual behaviour?

It used to be. I've now changed it because with the new behaviour
(confirm prompt not folded into other prompts) I think it makes
sense to show all possible recipient headers: "Oh, no Bccc, will
cancel that one."

>> +        if not ans.lower().startswith('y'):
>> +            ui.write(_('patchbomb canceled\n'))
>> +            return
> Spelling: it's "cancelled" according to my recollection and my local aspell.

British or American? Or?

> Other than that, I like it.

Mads also pointed out that the (already existing) prompt handling
in patchbomb can't be localized. I will try to make it similar to
filemerge.py's prompts.

theatre - books - texts - movies
Black Trash Productions at home: http://www.blacktrash.org/
Black Trash Productions on Facebook:

More information about the Mercurial-devel mailing list