[PATCH 2 of 3] patchbomb: customize promptchoice to allow localization of choices

[Mads Kiilerich]

On 08/28/2010 11:44 AM, Christian Ebert wrote:
> * Christian Ebert on Saturday, August 28, 2010 at 01:03:42 +0100
>> * Mads Kiilerich on Saturday, August 28, 2010 at 00:01:37 +0200
>>> --diffstat apparently does something quite similar to what you
>>> introduce with --confirm.
>>
>> It asks for confirmation of the diffstat of each patch. 3 patches
>> ->  3 prompts. confirm: 3 patches: 1 prompt. And, well, diffstat
>> shows the diffstat, and confirm shows the message details,
>> sender, recipients, subjects.
>>
>>> What is your thoughts regarding that? Are both of them needed and do
>>> they supplement each other? Could --diffstat be expanded instead of
>>> introducing a new option - or should --diffstat be deprecated?
>>
>> Frankly, I don't understand you there. Sorry.
>
> In my eyes there's a fundamental difference between diffstat and
> confirm, as diffstat changes the messages themselves. That's why
> the 2 options only overlap by presenting a boolean prompt (and
> diffstat does this for each patch as well for the whole series)
> and not in their, errmh, content ... But I probably still don't
> understand your question.

I doubt there is an answer, so it probably wasn't a question at all ...

I just wanted to raise some attention to the fact that we now are 
introducing a second completely different option for patchbomb 
confirmation.

It is unfortunate that --diffstat does two completely different things. 
Couldn't that be considered a ui bug that should be fixed? ;-)

It could be nice if the two kind of prompts could be unified somehow. 
That is however probably hard to do while preserving backward 
compatibility. The fact that it is an interactive command makes 
scripting less of an issue, but still there might be some users that are 
used to rely on the prompts and would get an unpleasant surprise if it 
was changed ...

IMHO, ideally --diffstat should _only_ cause diffstat to be put in the 
mails. It would be fine with me if --confirm always showed diffstat 
together with each subject and was the only way to get a confirmation 
prompt.

/Mads