[PATCH 00 of 10] PyPy support

Matt Mackall mpm at selenic.com
Wed Dec 1 19:15:28 CST 2010


On Wed, 2010-12-01 at 22:34 +0100, Dan Villiom Podlaski Christiansen
wrote:
> Hi,
> 
> This series fixes most of the test suite failures when running
> Mercurial under PyPy 1.4. I've only tested a pure Python build; the C
> modules won't compile as PyPy's cpyext interface lacks the
> PyFile_GetLine and PyErr_SetFromErrnoWithFilename APIs.

A good benchmark would be running verify.

In the future, you should stick the patches that are uncontroversial
first. In this case, that looks like 1, 7, maybe 8, 9, and 10?

I'd like some explanation of what's going on in 7.

As for the rest, there are numerous places in the Python docs where
reference counting is described as the primary memory management method.
In fact, it's the garbage collector, not the reference counter that's
described as optional.

If the Pypy people think that diverging from CPython in a way that
changes semantics so much that we have to audit all our file handling to
be safe/compatible, they're really not aiming at widespread use of their
toy, are they?

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list