[PATCH] avoid .split() for loops and use tuples instead

dsp at php.net dsp at php.net
Wed Dec 1 19:25:54 CST 2010


# HG changeset patch
# User David Soria Parra <dsp at php.net>
# Date 1291253020 -3600
# Node ID 24a46ecd358c023f7e55b67e8df491b521fe81be
# Parent  77aa74fe0e0b92945ec793e9e7af02fdda36ca7c
avoid .split() for loops and use tuples instead

split can be more readable for longer lists like the list in
dirstate.invalidate. As dirstate.invalidate is used in wlock() and therefoe
used heavily, I think it's worth avoiding a split there too.

diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py
--- a/mercurial/dirstate.py
+++ b/mercurial/dirstate.py
@@ -230,7 +230,8 @@
             self._pl = p
 
     def invalidate(self):
-        for a in "_map _copymap _foldmap _branch _pl _dirs _ignore".split():
+        for a in ("_map", "_copymap", "_foldmap", "_branch", "_pl", "_dirs",
+                "_ignore"):
             if a in self.__dict__:
                 delattr(self, a)
         self._dirty = False
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -735,7 +735,7 @@
         self._branchcachetip = None
 
     def invalidate(self):
-        for a in "changelog manifest".split():
+        for a in ("changelog", "manifest"):
             if a in self.__dict__:
                 delattr(self, a)
         self.invalidatecaches()
diff --git a/mercurial/util.py b/mercurial/util.py
--- a/mercurial/util.py
+++ b/mercurial/util.py
@@ -1094,7 +1094,7 @@
         if not defaults:
             defaults = {}
         now = makedate()
-        for part in "d mb yY HI M S".split():
+        for part in ("d", "mb", "yY", "HI", "M", "S"):
             if part not in defaults:
                 if part[0] in "HMS":
                     defaults[part] = "00"
@@ -1139,7 +1139,7 @@
 
     def upper(date):
         d = dict(mb="12", HI="23", M="59", S="59")
-        for days in "31 30 29".split():
+        for days in ("31", "30", "29"):
             try:
                 d["d"] = days
                 return parsedate(date, extendeddateformats, d)[0]


More information about the Mercurial-devel mailing list