[PATCH 1 of 1 RFC] tag: abort if not at a branch head

Wagner Bruna wagner.bruna+mercurial at gmail.com
Tue Dec 7 08:02:10 CST 2010


On 12/06/2010 10:14 PM, Matt Mackall wrote:
> On Mon, 2010-12-06 at 13:56 -0600, Kevin Bullock wrote:
>> # HG changeset patch
>> # User Kevin Bullock <kbullock at ringworld.org>
>> # Date 1291665075 21600
>> # Node ID f52e752c6d5f90352bb29ba6c2543656f6e4531e
>> # Parent  8c6b7a5f38c4585b1b2c2ceaffa8023f36a18479
>> tag: abort if not at a branch head
>>
>> Since it's usually only desirable to make tag commits on top of branch
>> heads, abort if the working dir parent is not a branch head. -f/--force
>> may be passed to commit at a non-head anyway.
> 
> I'm hard-pressed to think of any realistic use cases for committing a
> tag at somewhere other than a branch head. Can anyone think of one?

Says a user updates to the desired revision, tests it, thinks "all
tests pass, I'd like to tag this", and immediately calls "hg tag". To
me, it seems strange to demand him to update to the branch head before
tagging.

The current branch head may even be unrelated to the tagging; the user
could be working in parallel on a topological branch, with a bookmark.

OTOH, I personally prefer always commiting a tag at a descendant of
the tagged revision, to avoid getting a dangling tag on a selective
pull/push.

Regards,
Wagner


More information about the Mercurial-devel mailing list