[PATCH 2 of 8] bundle progress: offer best-guess deterministic progress information

Augie Fackler durin42 at gmail.com
Thu Dec 9 17:54:39 CST 2010


On Thu, Dec 9, 2010 at 5:53 PM, Matt Mackall <mpm at selenic.com> wrote:
> On Thu, 2010-12-09 at 17:41 -0600, Augie Fackler wrote:
>> # HG changeset patch
>> # User Augie Fackler <durin42 at gmail.com>
>> # Date 1291935948 21600
>> # Node ID 130377d187a10fdc2f55ad8957ef1b7becada7fa
>> # Parent  a6a1d02d1d1ad2d936a8a8324b5bb814d6bab480
>> bundle progress: offer best-guess deterministic progress information
>>
>> This uses the same strategy as progress for pulls, estimating manifests
>> based on changeset count and estimating file count by files list in
>> each changeset.
>>
>> diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
>> --- a/mercurial/localrepo.py
>> +++ b/mercurial/localrepo.py
>> @@ -1505,7 +1505,9 @@
>>              group = cl.group(msng_cl_lst, identity, collect)
>>              for cnt, chnk in enumerate(group):
>>                  yield chnk
>> -                self.ui.progress(_('bundling changes'), cnt, unit=_('chunks'))
>> +                self.ui.progress(_('bundling changes'), cnt/3,
>
> What's going on with this cnt/3?

changegroups have 3 yield statements per node in the group stream. I
should add a comment. I'll wait for comments on the rest of the series
before resending.

>
> --
> Mathematics is the supreme nostalgia of our time.
>
>
>


More information about the Mercurial-devel mailing list