[PATCH] atomictempfile: avoid infinite recursion in destructor

Greg Ward greg-hg at gerg.ca
Mon Dec 13 12:56:27 CST 2010

On Mon, Dec 13, 2010 at 1:10 PM, Matt Mackall <mpm at selenic.com> wrote:
>> Anyways, I'll give this patch a workout this afternoon and see if
>> anything goes wrong.  But would you care to explain what you mean by
>> "issues with posixfile that need to get sorted out"?  I don't *see*
>> anything fishy from reading the code...
> See util.posixfile. A posixfile is a file with sensible behavior, as
> opposed to what open() on Windows gives us.

You must be referring to the Windows-specific posixfile() in osutil.c.
 Looks to me like it returns a real genuine Python file object, not a
file-like object.  I still don't see anything fishy from reading the
code.  And I don't know squat about Mercurial on Windows -- it just
works for me, so I have studiously avoided having to learn how to
build/test on Windows.

Either that or you are referring to

posixfile = open

in posix.py, which obviously gives a genuine Python file object with
POSIX semantics.


More information about the Mercurial-devel mailing list