[PATCH] progress: don't compute estimate without a total
adrian at cadifra.com
Thu Dec 16 08:07:21 CST 2010
On 2010-12-16 14:44, Augie Fackler wrote:
> On Dec 16, 2010, at 1:54 AM, Adrian Buehlmann wrote:
>> On 2010-12-16 05:05, Augie Fackler wrote:
>>> # HG changeset patch
>>> # User Augie Fackler <durin42 at gmail.com>
>>> # Date 1292472327 21600
>>> # Node ID 3b79ee2fca7d1f00d4fef7164e8d6e88f42c0dfe
>>> # Parent 94507fd06ebc1516d4141a411cb27ec7534fa3a9
>>> progress: don't compute estimate without a total
>>> Without this, computing an estimate explodes gloriously. Test
>> A word like 'explode' might be funny for some people in a mailing list
>> post or in IRC chat, but IMHO it shouldn't be used in change message
>> text, tests or code.
>> I assume you mean: 'fails with a traceback'?
> I don't understand why you think it so inappropriate, I've seen it used not infrequently in this context. That said, I don't feel strongly so I'll resend.
Well, it left me slightly puzzled for a second how a progress bar might
possibly explode. Until I read the code change.
But I see now that we already have one precedent:
$ hg log -r "keyword('explode')"
user: Alexis S. L. Carvalho <...>
date: Thu Jul 06 03:14:55 2006 -0300
summary: HTTPS: fix python2.3, persistent connections, don't explode
if SSL is not available
But crash is definitely more frequent in mercurial's history
$ hg log -qr "keyword('crash')"
More information about the Mercurial-devel