[PATCH 2 of 2 STABLE] convert: subversion should use util.quotecommand to wrap args to popen2
Steve Borho
steve at borho.org
Wed Dec 22 13:40:19 CST 2010
# HG changeset patch
# User Steve Borho <steve at borho.org>
# Date 1293045900 21600
# Branch stable
# Node ID 375369de1bfe823c2b593506e3f24e37e235d37c
# Parent 6c9345f9edca6d7ea4b368b1845f5f6896b9d529
convert: subversion should use util.quotecommand to wrap args to popen2
All other callers of util.popen2 and util.popen3 do this, as well as direct
callers of subprocess.Popen.
diff -r 6c9345f9edca -r 375369de1bfe hgext/convert/subversion.py
--- a/hgext/convert/subversion.py Wed Dec 22 13:25:00 2010 -0600
+++ b/hgext/convert/subversion.py Wed Dec 22 13:25:00 2010 -0600
@@ -914,7 +914,7 @@
arg = encodeargs(args)
hgexe = util.hgexecutable()
cmd = '%s debugsvnlog' % util.shellquote(hgexe)
- stdin, stdout = util.popen2(cmd)
+ stdin, stdout = util.popen2(util.quotecommand(cmd))
stdin.write(arg)
try:
stdin.close()
More information about the Mercurial-devel
mailing list