[PATCH 4 of 8] opener: add read & write utility methods

Adrian Buehlmann adrian at cadifra.com
Sat Dec 25 05:51:14 CST 2010

On 2010-12-25 12:29, Dan Villiom Podlaski Christiansen wrote:
> On 25 Dec 2010, at 01:48, Adrian Buehlmann wrote:
>> On 2010-12-25 01:35, Dan Villiom Podlaski Christiansen wrote:
>>> @@ -221,6 +223,8 @@ class encodedstore(basicstore):
>>>         op = opener(self.path)
>>>         op.createmode = self.createmode
>>>         self.opener = lambda f, *args, **kw: op(encodefilename(f),  
>>> *args, **kw)
>>> +        self.opener.read = (lambda f, *args, **kw:
>>> +                            op(encodefilename(f), *args, **kw).read 
>>> ())
>> I hope this is not pushed, like I already said.
>> Dan and I disagree here but he insists on this.
> So I insist, eh? You didn't respond to my mail where I explained why I  
> did it, and later posted a mail describing how you'd like it done. So  
> I just assumed that we agreed to disagree.

Yes we do disagree. An yes you quite obviously insist on having your
change this way. What is resending it unchanged other than insisting?

I wonder though how we two can (or should) make progress in this manner.
Explaining your way isn't making your way better at all.

> This is all the reasoning you've provided:
>> IMHO, this is too intrusive. You shouldn't have to add a read member  
>> function to
>> every opener.
> Please elaborate.

I think that's pointless at this point. Let's see if Matt takes you
patch or not.

More information about the Mercurial-devel mailing list