[PATCH 4 of 8] opener: add read & write utility methods

Nicolas Dumazet nicdumz at gmail.com
Mon Dec 27 05:31:04 CST 2010


2010/12/25 Adrian Buehlmann <adrian at cadifra.com>
>>
>>> IMHO, this is too intrusive. You shouldn't have to add a read member
>>> function to
>>> every opener.
>>
>> Please elaborate.
>
> I think that's pointless at this point. Let's see if Matt takes you
> patch or not.

Adrian, do we have alternatives here?
If you can come up with an alternate patch or suggestion that ensures
that things just work (tm) for PyPy, I'd gladly hear it.

I'm not saying that Dan's approach is perfect, but either we want to
support PyPy and we'll have to think harder about solutions.... or we
could give up and say upfront that we do not plan on supporting PyPy
ever. As far as I know the latter is not an option...

I do not use Windows, and yet this "Patrick" I've never ever met ( ;)
complains regularly that I break his stuff and that I should care...
See what I mean here?

Cheers!
-- 
Nicolas Dumazet — NicDumZ


More information about the Mercurial-devel mailing list