[PATCH 2 of 2] Convert: add tests for glob exclude patterns

[Greg Ward]

On Tue, Feb 2, 2010 at 2:07 PM, Tessa Starkey <testarkey at gmail.com> wrote:
> # HG changeset patch
> # User Tessa Starkey <testarkey at gmail.com>
> # Date 1265132657 18000
> # Node ID f3b48c94b2a6d1e61e3b8225aecfc3d241df147c
> # Parent  052ab4a8d877c59c398a7ed2f52644387dc56d9b
> Convert: add tests for glob exclude patterns

The usual convention around here is to include test changes in the
some patch as the new feature.

> diff --git a/tests/test-convert-filemap b/tests/test-convert-filemap
> --- a/tests/test-convert-filemap
> +++ b/tests/test-convert-filemap
> @@ -128,3 +130,16 @@
>  hg --cwd source cat copied
>  echo 'copied2:'
>  hg --cwd renames.repo cat copied2
> +
> +cat > globs.fmap <<EOF
> +exclude dir/file2
> +glob_exclude b*
> +rename dir dir2
> +rename foo foo2
> +glob_exclude */h?.py
> +EOF

It looks like you are not testing the case of overlapping patterns,
i.e. the warning in checkglob() is not being tested.

Greg