[PATCH] keyword: reduce pylint warnings by renaming some variables
Dirkjan Ochtman
dirkjan at ochtman.nl
Tue Feb 9 07:19:15 CST 2010
On Tue, Feb 9, 2010 at 14:16, Benoit Boissinot
<benoit.boissinot at ens-lyon.org> wrote:
>> What pylint warning does this fixed? This seems like it might be overdoing it.
>
> W0621:166:kwtemplater.overwrite: Redefining name 'files' from outer scope (line 375)
> W0621:166:kwtemplater.overwrite: Redefining name 'expand' from outer scope (line 365)
Okay, in that case it makes some amount of sense.
I do recognize that pylint has value in that it helps reducing some
classes of bugs, but sometimes it complains about perfectly valid
code.
Cheers,
Dirkjan
More information about the Mercurial-devel
mailing list