[PATCH] keyword: reduce pylint warnings by renaming some variables

Christian Ebert blacktrash at gmx.net
Tue Feb 9 07:53:16 CST 2010


* Dirkjan Ochtman on Tuesday, February 09, 2010 at 14:19:15 +0100
> On Tue, Feb 9, 2010 at 14:16, Benoit Boissinot
> <benoit.boissinot at ens-lyon.org> wrote:
>>> What pylint warning does this fixed? This seems like it might be overdoing it.

Overdoing is my occupational disease.

>> W0621:166:kwtemplater.overwrite: Redefining name 'files' from outer scope (line 375)
>> W0621:166:kwtemplater.overwrite: Redefining name 'expand' from outer scope (line 365)
> 
> Okay, in that case it makes some amount of sense.
> 
> I do recognize that pylint has value in that it helps reducing some
> classes of bugs, but sometimes it complains about perfectly valid
> code.

I know. I wasn't acting in complete blind obedience to pylint
though, but please feel free to treat the patch as a practical
inquiry (on how pylintish one should get) only, albeit overdone.

c
-- 
All of old. Nothing else ever. Ever tried. Ever failed.
No matter. Try again. Fail again. Fail better.
--Samuel Beckett, Worstward Ho


More information about the Mercurial-devel mailing list