[PATCH] keyword: reduce pylint warnings by renaming some variables

Mads Kiilerich mads at kiilerich.com
Tue Feb 9 18:55:17 CST 2010


Benoit Boissinot wrote, On 02/09/2010 02:23 PM:
> On Tue, Feb 09, 2010 at 02:19:15PM +0100, Dirkjan Ochtman wrote:
>    
>> On Tue, Feb 9, 2010 at 14:16, Benoit Boissinot
>> <benoit.boissinot at ens-lyon.org>  wrote:
>>      
>>>> What pylint warning does this fixed? This seems like it might be overdoing it.
>>>>          
>>> W0621:166:kwtemplater.overwrite: Redefining name 'files' from outer scope (line 375)
>>> W0621:166:kwtemplater.overwrite: Redefining name 'expand' from outer scope (line 365)
>>>        
>> Okay, in that case it makes some amount of sense.
>>
>> I do recognize that pylint has value in that it helps reducing some
>> classes of bugs, but sometimes it complains about perfectly valid
>> code.
>>      
> This is indeed the case (eg when it can't detect the type of super), and
> I don't plan on fixing those (I might blacklist the warning if
> necessary).
>    

pylint is a funny little project to hack on - especially if you are a 
language geek. So don't rule out the possibility of fixing pylint 
complaints by helping the logilab guys improve pylint ;-)

/Mads


More information about the Mercurial-devel mailing list