[PATCH 1 of 1] sshserver: add varargs capability

Augie Fackler lists at durin42.com
Wed Feb 10 11:07:00 CST 2010


On Wed, Feb 10, 2010 at 10:22 AM, Dirkjan Ochtman <dirkjan at ochtman.nl> wrote:
> On Wed, Feb 10, 2010 at 17:04, Augie Fackler <lists at durin42.com> wrote:
>> Having just implemented chunked transfer encoding, I'm confident we
>> can't tuck extra information into the chunk headers at the http level.
>> When we read from the http response object, we're totally oblivious of
>> the presence of chunked transfers.
>
> I implemented a version of chunked where we reach through httplib to
> the underlying socket, it's quite easy to do (as a client, anyway).

Oh, for sure, but if we put it in the stream protocol itself then we
don't to have to kludge around in the http client, and it's simpler to
add new transports if we ever want to. Mucking around in the chunked
transfer level itself just feels like a layering violation.

>
> Cheers,
>
> Dirkjan
>


More information about the Mercurial-devel mailing list