[PATCH] dirstate: make subrepos an optional arg to status() and walk()

Augie Fackler durin42 at gmail.com
Mon Feb 15 10:16:02 CST 2010


On Feb 15, 2010, at 9:51 AM, Augie Fackler wrote:

> 
> On Feb 15, 2010, at 9:25 AM, Greg Ward wrote:
> 
>> # HG changeset patch
>> # User Greg Ward <greg-hg at gerg.ca>
>> # Date 1266244676 18000
>> # Node ID a69774706574b6f88cf1d695a2b3485d959ca9f9
>> # Parent  ed4de30e16c5b6efb67a2a5edabb424cd4deda7d
>> dirstate: make subrepos an optional arg to status() and walk().

[...]

>> -        def status(self, match, subrepos, ignored, clean, unknown=True):
>> +        def status(self, match, ignored, clean, unknown=True, subrepos=None):
> 
> FWIW, I originally had it like this, and (if I remember properly) mpm explicitly wanted it moved.

Found it (context: the subrepos arg used to be just "skip" or "skiplist", but mpm deemed that too generic, and also wanted it explicitly clear of the flags in the list):

2009-12-31, #mercurial:
17:07 < mpm> Let's make skiplist arg after match.
17:07 < durin42> Alright, can do.
17:08 < mpm> And call it subs or subrepos.
17:08 < durin42> subrepos sounds less ambiguous to me, I'll go with that
17:09 < mpm> I think this might be the last iteration before merging.
17:10 < durin42> Cool, starting now, might finish before dinner.
17:10 < durin42> should be quick
17:10 < durin42> skip ok at the end of dirstate.status()?
17:10 < durin42> or right after match there too?
17:10 < durin42> s/skip/subrepos/g
17:10 < mpm> Before the bool args, please.
17:11 < mpm> (flags at the end is a good pattern)
17:11 < durin42> very good

[...]


More information about the Mercurial-devel mailing list