RFC: Fix for issue 1827 (v2)

Sune Foldager cryo at cyanite.org
Mon Feb 15 17:37:44 CST 2010


On 16-02-2010 00:34, Benoit Boissinot wrote:
> On Mon, Feb 15, 2010 at 11:30:23PM +0100, Sune Foldager wrote:

> I don't think we should move the hook up one level, every other commit
> related hook is fired on commitctx, why should it be different for this
> one?

Because that's how the bug can get fixed (if we want to fix it). The
commit hook can't fire until wlock has been released, or commands
running in it won't see the correct view of the world. Moving the wlock
stuff around is a much bigger deal.

For update, the hook can stay in the same function, though.

/Sune


More information about the Mercurial-devel mailing list