RFC: Fix for issue 1827 (v2)

Greg Ward greg-hg at gerg.ca
Mon Feb 15 19:43:51 CST 2010


On Mon, Feb 15, 2010 at 6:46 PM, Benoit Boissinot
<benoit.boissinot at ens-lyon.org> wrote:
> I see. So we assume nobody who calls commitctx() directly assumes hooks
> will be fired?

Eeek.  I for one don't currently rely on this property, but IMHO it's
a good one that's worth keeping.  Calling all commit-related hooks
from the same level feels deeply right to me.

> Do we want to keep some sort of symmetry and move precommit up too?

I vote conservative here: keep calling the hooks from commitctx().  If
that means pain moving wlock stuff around, so be it.  (Well, depending
on the degree of pain... ;-)

Greg


More information about the Mercurial-devel mailing list