RFC: Fix for issue 1827 (v2)

Benoit Boissinot bboissin at gmail.com
Tue Feb 16 01:33:41 CST 2010


[please keep the cc list]

On Tue, Feb 16, 2010 at 2:43 AM, Greg Ward <greg-hg at gerg.ca> wrote:
> On Mon, Feb 15, 2010 at 6:46 PM, Benoit Boissinot
> <benoit.boissinot at ens-lyon.org> wrote:
>> I see. So we assume nobody who calls commitctx() directly assumes hooks
>> will be fired?
>
> Eeek.  I for one don't currently rely on this property, but IMHO it's
> a good one that's worth keeping.  Calling all commit-related hooks
> from the same level feels deeply right to me.

Yes but on the other hand there's a bunch of hooks that might be
confused if a memctx is committed, since there will be no
corresponding working dir to work with!

Benoit


More information about the Mercurial-devel mailing list