Should bfiles auto-status affect all uses of localrepo.status?

Anton Markov anton.markov at gmail.com
Wed Feb 17 16:44:12 CST 2010


I would like some input on a question that would affect other parts of
mercurial and other extensions if 'hg status' incorporates output of 'hg
bfstatus'.

Currently, 'hg status' simply pretty-prints the output of the
localrepo.status function which is also used by other parts of mercurial. I
am trying to decide if I want to (A) alter the output of 'hg status' to
include 'hg bfstatus' but leave the output of localrepo.status unchanged, or
(B) to change the output of localrepo.status[1].

Pros (A): doesn't affect other code, easier to implement
Cons (A): the user may get confused if 'hg status' shows a big file, but
another command using localrepo.status ignores that file.

Pros (B): consistent handling of big file status
Cons (B): other callers of localrepo.status may not be expecting files that
are not actually in the repository.

For background information, please see: 
http://selenic.com/pipermail/mercurial-devel/2010-February/018405.html

Your input will be appreciated.


Thanks,
Anton


[1] I would use extensions.wrapfunction(repo, status, ...) from within
reposetup  of the extension.



More information about the Mercurial-devel mailing list