bdiff stack overflow patch

Benoit Boissinot bboissin at gmail.com
Thu Feb 18 03:07:47 CST 2010


On Fri, Jan 29, 2010 at 6:38 AM, Matt Mackall <mpm at selenic.com> wrote:
> On Tue, 2009-12-08 at 14:23 -0500, Alistair Bell wrote:
>> As mentioned in http://mercurial.selenic.com/bts/issue1940 I found
>> that I was getting a stack overflow in bdiff. You could possibly blame
>> GCC 3.4.6 for not recognizing that it should optimize the code as tail
>> recursion, but I converted the tail recursion to iteration and the
>> problems went away.
>
> Queued for main, thanks. Next time use hg export or patchbomb, please.

This was never actually pushed, right?

Benoit


More information about the Mercurial-devel mailing list