Should bfiles auto-status affect all uses of localrepo.status?

Christian Ebert blacktrash at gmx.net
Thu Feb 18 09:54:09 CST 2010


* Greg Ward on Thursday, February 18, 2010 at 10:20:45 -0500

<snip>

> But you are quite right: wrapping localrepository.status() could have
> unintended consequences elsewhere in Mercurial.  Well, OK, when in
> doubt, audit the code.  I'm just scanning all the Mercurial source for
> lines matching '\.status(' but not 'ui\.status'.  Here's what I'm
> finding...

<snip>

> 15) cmdutil uses it in the general-purpose utility function
> bail_if_changed(), which should probably be used by fetch, keyword,
> mq, and transplant ;-)

I first used it in keyword, but:

http://www.blacktrash.org/hg/hgkeyword/rev/2088e409d360

cmdutil.bail_if_changed() first checks for an uncommitted merge
(the part I need in keyword), but then whether files have
changed, and I just want to find out whether hg kwexpand or hg
kwshrink would attack files that have changed. It's ok to run
these commands on files that haven't.

c
-- 
  Was heißt hier Dogma, ich bin Underdogma!
[ What the hell do you mean dogma, I am underdogma. ]

_F R E E_  _V I D E O S_  --->>> http://www.blacktrash.org/underdogma/


More information about the Mercurial-devel mailing list