[PATCH] mercurial.spec: Install mq.el, hgk requires tk, uncompressed man pages

Mads Kiilerich mads at kiilerich.com
Tue Jan 5 20:01:20 CST 2010


Matt Mackall wrote, On 01/05/2010 06:44 PM:
> On Tue, 2010-01-05 at 11:40 +0100, timeless wrote:
>    
>> On Tue, Jan 5, 2010 at 11:20 AM, Mads Kiilerich<mads at kiilerich.com>  wrote:
>>      
>>>> hgk is an extension being deprecated, and which is not activated by
>>>> default.
>>>> So I am reluctant to this requirement.
>>>>          
>>> hgk should either work or not be installed. Which one would you prefer?
>>>        
>> a. split it to its own package
>> b. use a 'recommends' (fairly bogus)
>>      
> Is there not something analogous to contrib/ in the packaging system?
> Debian likes to put these sorts of things in /usr/share/doc/foo/examples
> or similar.
>    

What sort of things? hgk? Or contrib in general?

Does that mean that you don't think hgk should be installed in a working 
place? Because this extension is deprecated? Or because nothing from 
contrib should be installed?

> There are at least half a dozen things in contrib/ that should get
> installed -somewhere- on a user's system. It'd probably be best if the
> whole directory were copied.
>    

Yes, stuff which isn't used directly and have no formal purpose but more 
serves like documentation or templates is often installed in doc. And 
working but seldom used executable scripts are often placed in libexec. 
And files for integration and configuration should be installed the 
right place.

I don't understand what the contrib folder is for. Is it unsupported or 
undocumented? Broken stuff? The place where all contributions go? Or 
just a place where random things are dumped and forgotten? I don't think 
anybody would benefit from just including the whole contrib folder as-is 
in the installer/package.

Some things in contrib I think should be cleaned up:

Shouldn't the git-viz folder have been removed with 6a0d373d3126?

Why convert-repo? Haven't it been fully replaced by the convert 
extensions? All occurences of the string convert-repo seems invalid. Is 
there any reason to carry and install this?

tmplrewrite.py seems very undocumented. Do it still serve a purpose as 
it is?

vim/patchreview.txt and vim/patchreview.vim seems to not be hg related 
and lives on http://www.vim.org/scripts/script.php?script_id=1563 - why 
should we include them?

vim/hgcommand.vim and vim/HGAnnotate.vim says that they are not 
recommended for vim 7 or later. Vim 7 was released in 2006. Are they 
relevant?

vim/hg-menu.vim seems to be for vim 6 and haven't been touched for 4 
years. Is it still working and used?

Is hgsh still alive? It is not mentioned in wiki and haven't been 
touched for ages.

/Mads


More information about the Mercurial-devel mailing list