[PATCH] mq: qfinish -a should check for translated default commit messages and abort

[Martin Geisler]

David Soria Parra <sn_ at gmx.net> writes:

> # HG changeset patch
> # User David Soria Parra <dsp at php.net>
> # Date 1263992171 -3600
> # Node ID b56775616552a93d7832104d24794ee9fe3c25a1
> # Parent  a9c0d6060827edf92106ed00430e96d524fc2d8d
> mq: qfinish -a should check for translated default commit messages and abort.
>
> Currently mq qfinish -a only checks for the english version of
> "imported patch" to detect if a patch has an empty commit message. We
> have to use the i18n version of it. As the i18n version is newline
> terminated, we have to strip the newline after the translation to
> ensure the match works.

Nice catch! However, we stopped translating all the automatic commit
messages some time ago -- like the one you get when adding a tag.

So perhaps we should fix this by not translating the message in the
first place?

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20100120/c61920ee/attachment.pgp>