svn subrepo and solaris and en_US.UTF-8

[Martin Geisler]

Patrick Mézard <pmezard at gmail.com> writes:

> Le 20/01/10 12:24, Martin Geisler a écrit :
>> Patrick Mézard <pmezard at gmail.com> writes:
>> 
>> If I understand you correctly, then you're saying that it is wrong
>> for Mercurial to run SVN with a C locale -- it breaks if the subrepo
>> contains non-ASCII filenames. Picking UTF-8 is wrong too, if the user
>> expects another locale, or if there is no UTF-8 locale.
>> 
>> So I think we should run SVN with the same locale as Mercurial itself
>> it run. The problems would then be the same as if the user had made a
>> checkout himself using that locale.
>
> The problem with running with current locale is messages are
> translated and we parse them.

Oh, right... I had forgotten that we go that route instead of using a
proper library :-( But on the other hand, supporting SVN out of the box
is nice too, so I guess it's worth it.

> I have a fix changing LC_MESSAGES=C. It seems to work at least on OSX,
> I have not tried on Windows yet. And it should prevent encoding issues
> with svn inputs.

Good idea about setting LC_MESSAGES=C only!

>>> For the first problem, we should use --xml calls whenever possible,
>>> use command exit status when possible, then check the remaining
>>> commands and adapt the code.
>> 
>> Using --xml sounds like a good idea!
>
> I have a working (at least in tests) version of this using
> xml.dom.minidom. It also handles changes to meta and externals. I will
> post them soon.

Wow, I'm impressed by all the fixes and patches you can churn out!

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20100121/34d2d74e/attachment.pgp>