[PATCH] patchbomb: don't prompt for cc when cc is set without value

Christian Ebert blacktrash at gmx.net
Fri Jan 22 10:13:40 CST 2010


Hi David,

* David Soria Parra on Friday, January 22, 2010 at 16:49:34 +0100
>> +        # do not prompt for Cc when it is configured explicitly empty
>> +        if opt == 'cc' and ui.config('email', opt) == '':
>> +            prpt = None
> Shouldn't we also check for ui.config('patchbomb', opt) == '', too?

Ah, by now I've detected the checks for a patchbomb section in
patchbomb.py. Is it documented somewhere?

> Apart from that I think the patch looks good.
> 
> if opt == 'cc' and (ui.config('email', opt) == '' or
> ui.config('patchbomb', opt) == '')

Sure. I'll resend.

c
-- 
\black\trash movie   _M O R A L I S K_  _A N S T A L T_
                                      "Nix verstanden."

--->> http://www.blacktrash.org/underdogma/moraliskanstalt.php


More information about the Mercurial-devel mailing list