[PATCH 0 of 4] patchbomb: reduce cc prompts; documentation and help tweaks

Christian Ebert blacktrash at gmx.net
Sat Jan 23 09:54:06 CST 2010


* Christian Ebert on Saturday, January 23, 2010 at 13:37:08 +0100
> Here are 4 patches concerning patchbomb:
> 
> 1. removes a description specific to patchbomb behaviour from
>   hgrc.5.
> 
> 2. documents the use of [patchbomb] as configuration section.
> 
> 3. changes patchbomb behaviour wrt to the Cc prompt:
>   prompts are reduced to those cases when Cc is
>   a) not configured AND b) --to option is not given.
> 
> 4. is a cosmetic change and can of course be left out.
> 
> 
> After discussing 3. on irc and lengthy testing this behaviour
> change makes the most sense to me:
> 
> a) it does not introduce any magic evaluation of hgrc like my
>   previous patch does ("cc =" suppresses prompt), even though
>   it made some sense from the user's pov: "I want to _configure_
>   whether or not I'm prompted for Cc. The clean way would then
>   be to have a (additional) boolean like `askcc'.
> 
> b) the behaviour change is minimal: only 2 cases.
> 
> For reference I include the table from the 3rd patch's
> description again here (* marks behaviour change):
> 
> 
> opts     hgrc     prompt   result
>                  new/old
> 
> to, cc            NO       to (opts), cc (opts)
> to, cc   to       NO       to (opts), cc (opts)
> to, cc   cc       NO       to (opts), cc (opts)
> to, cc   to, cc   NO       to (opts), cc (opts)
> 
> to                NO/cc    to (opts)         *
> to       to       NO/cc    to (opts)         *
> to       cc       NO       to (opts), cc (hgrc)
> to       to, cc   NO       to (opts), cc (hgrc)
> 
> cc                to       to (prompt), cc (opts)
> cc       to       NO       to (hgrc), cc (opts)
> cc       cc       cc       to (prompt), cc (opts)
> cc       to, cc   NO       to (hgrc), cc (opts)
> 
>                  to, cc   to (prompt), cc (prompt)
>         to       cc       to (hgrc), cc (prompt)
>         cc       to       to (opts), cc (hgrc)
>         to, cc   NO       to (hgrc), cc (hgrc)

patch queue at
http://www.blacktrash.org/hg/hg-queue/

crew repo with patch queue on top at
http://www.blacktrash.org/hg/hg-crew-mq/

c
-- 
\black\trash movie   _M O R A L I S K_  _A N S T A L T_
                                      "Nix verstanden."

--->> http://www.blacktrash.org/underdogma/moraliskanstalt.php


More information about the Mercurial-devel mailing list