[PATCH 4 of 4] patchbomb: display recipients and ask for confirmation

[Mads Kiilerich]

Christian Ebert wrote, On 01/26/2010 09:25 PM:
> diff --git a/tests/test-patchbomb.out b/tests/test-patchbomb.out
> --- a/tests/test-patchbomb.out
> +++ b/tests/test-patchbomb.out
> @@ -1,6 +1,9 @@
>   adding a
>   This patch series consists of 1 patches.
>
> +To: foo
> +Cc: bar
>    

FWIW I think it would be nice to see more to convince me _what_ is about 
to be sent. Most obvious would be the From field and all the full 
subjects including the --flags. A last review of the intro message could 
perhaps also be convenient - but I'm not sure about that one ...

(It would move in the direction of the -n option, but that is way too 
verbose for this purpose.)

> +send patchbomb to the recipients listed above? [y] y
>    

Nice!

Have you considered if that change of behaviour is acceptable 
considering backward compatibility?

Anyway, I like that the prompt is on by default, but think it must be 
possible to disable it somehow. Perhaps a --noprompt option?

/Mads