[PATCH 4 of 4] patchbomb: display recipients and ask for confirmation

Christian Ebert blacktrash at gmx.net
Wed Jan 27 00:49:26 CST 2010


* Mads Kiilerich on Wednesday, January 27, 2010 at 00:28:25 +0100
> Christian Ebert wrote, On 01/26/2010 09:25 PM:
>> diff --git a/tests/test-patchbomb.out b/tests/test-patchbomb.out
>> --- a/tests/test-patchbomb.out
>> +++ b/tests/test-patchbomb.out
>> @@ -1,6 +1,9 @@
>> adding a
>> This patch series consists of 1 patches.
>> 
>> +To: foo
>> +Cc: bar
> 
> FWIW I think it would be nice to see more to convince me _what_ is
> about to be sent. Most obvious would be the From field and all the
> full subjects including the --flags. A last review of the intro
> message could perhaps also be convenient - but I'm not sure about
> that one ...
> 
> (It would move in the direction of the -n option, but that is way
> too verbose for this purpose.)

Hm. That doesn't convince /me/ ;-) I would just just the -n flag
then. I don't mind it being verbose.

>> +send patchbomb to the recipients listed above? [y] y
> 
> Nice!
> 
> Have you considered if that change of behaviour is acceptable
> considering backward compatibility?

That's why I am making proposals.

> Anyway, I like that the prompt is on by default, but think it must
> be possible to disable it somehow. Perhaps a --noprompt option?

hg -y email ...

c
-- 
\black\trash movie    _C O W B O Y_  _C A N O E_  _C O M A_
                     Ein deutscher Western/A German Western

         --->> http://www.blacktrash.org/underdogma/ccc.php


More information about the Mercurial-devel mailing list