[PATCH 4 of 4] patchbomb: display recipients and ask for confirmation

Greg Ward greg-hg at gerg.ca
Wed Jan 27 21:26:43 CST 2010


On Tue, Jan 26, 2010 at 6:28 PM, Mads Kiilerich <mads at kiilerich.com> wrote:
> FWIW I think it would be nice to see more to convince me _what_ is about to
> be sent. Most obvious would be the From field and all the full subjects
> including the --flags. A last review of the intro message could perhaps also
> be convenient - but I'm not sure about that one ...

Enthusiastic "+1" from me on the whole patch!  I agree with Mads: I
would like to see the exact "Subject" line along with "To" and "Cc".
"From" too, I suppose: I don't want to accidentally use my internal
work address to send patches to a public mailing list.

> Have you considered if that change of behaviour is acceptable considering
> backward compatibility?

Considering that patchbomb is currently script-hostile (because of the
unconditional "Cc" prompt that Christian is getting rid of), I hope
this change is acceptable.  It will certainly make life easier for
anyone wishing to script patchbomb in future.

> Anyway, I like that the prompt is on by default, but think it must be
> possible to disable it somehow. Perhaps a --noprompt option?

I like -y with --no-prompt as the long form.

Greg


More information about the Mercurial-devel mailing list